lkml.org 
[lkml]   [2018]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/5] net: add an info message to eth_platform_get_mac_address()
From
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Wed, 18 Jul 2018 18:10:32 +0200

>
> + dev_info(dev, "read MAC address from %s\n", from);
> ether_addr_copy(mac_addr, addr);
> return 0;

Ugh, please don't do this.

We probe various bits of information from various sources during
driver probe, and none of them are more or less important than
the MAC address. So singling this out for log info output is
really not such a great idea.

Thank you.

\
 
 \ /
  Last update: 2018-07-19 01:14    [W:0.206 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site