lkml.org 
[lkml]   [2018]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH v2 3/8] Coccinelle: atomic_as_refcounter: Optimise a disjunction in the first SmPL rule
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 16 Jul 2018 17:43:49 +0200

    The variables “fname2” till “fname6” do not care for different function
    parameters in the disjunction at the end of a rule in a script
    for the semantic patch language.
    Thus reduce this disjunction by using a regular expression with
    an alternation for an optimised constraint.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    scripts/coccinelle/api/atomic_as_refcounter.cocci | 15 +--------------
    1 file changed, 1 insertion(+), 14 deletions(-)

    diff --git a/scripts/coccinelle/api/atomic_as_refcounter.cocci b/scripts/coccinelle/api/atomic_as_refcounter.cocci
    index 46d27b2b1dff..4da83ccfa6f6 100644
    --- a/scripts/coccinelle/api/atomic_as_refcounter.cocci
    +++ b/scripts/coccinelle/api/atomic_as_refcounter.cocci
    @@ -13,12 +13,7 @@ virtual report
    identifier a, x;
    position p1, p2;
    identifier fname =~ "free";
    -identifier fname2 =~ ".*destroy.*";
    -identifier fname3 =~ ".*del.*";
    -identifier fname4 =~ ".*queue_work.*";
    -identifier fname5 =~ ".*schedule_work.*";
    -identifier fname6 =~ ".*call_rcu.*";
    -
    +identifier fname2 =~ "(?:call_rcu|de(?:l|stroy)|(?:queue|schedule)_work)";
    @@

    (
    @@ -39,14 +34,6 @@ identifier fname6 =~ ".*call_rcu.*";
    fname@p2(a, ...);
    |
    fname2@p2(...);
    -|
    - fname3@p2(...);
    -|
    - fname4@p2(...);
    -|
    - fname5@p2(...);
    -|
    - fname6@p2(...);
    )


    --
    2.18.0
    \
     
     \ /
      Last update: 2018-07-16 19:29    [W:2.409 / U:2.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site