| From | Todd Poynor <> | Subject | [PATCH 23/32] staging: gasket: gasket_mmap return error instead of valid BAR index | Date | Mon, 16 Jul 2018 19:09:17 -0700 |
| |
From: Todd Poynor <toddpoynor@google.com>
When offset to be mapped matches both a BAR region and a coherent mapped region return an error as intended, not the BAR index.
Signed-off-by: Simon Que <sque@chromium.org> Signed-off-by: Todd Poynor <toddpoynor@google.com> --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index 131ae2462edc1..1d979772217bf 100644 --- a/drivers/staging/gasket/gasket_core.c +++ b/drivers/staging/gasket/gasket_core.c @@ -1630,7 +1630,7 @@ static int gasket_mmap(struct file *filp, struct vm_area_struct *vma) "0x%lx", raw_offset); trace_gasket_mmap_exit(bar_index); - return bar_index; + return -EINVAL; } vma->vm_private_data = gasket_dev; -- 2.18.0.203.gfac676dfb9-goog
|