lkml.org 
[lkml]   [2018]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] radix tree test suite: fix mapshift build target
    On Mon, Jul 16, 2018 at 12:52:49PM -0700, Matthew Wilcox wrote:
    > On Mon, Jul 16, 2018 at 10:07:10AM -0600, Ross Zwisler wrote:
    <>
    > OK ... what version of make are you using? Because this works fine for me:
    >
    > $ git clone linux clean
    > $ cd clean
    > $ git checkout v4.17
    > $ cd tools/testing/radix-tree/
    > $ git revert 8d9fa88edd5e360b71765feeadb915d4066c9684
    > $ make
    >
    > $ make --version
    > GNU Make 4.1
    > Built for x86_64-pc-linux-gnu
    >
    > It's Debian's Version: 4.1-9.1

    $ make --version
    GNU Make 4.2.1
    Built for x86_64-redhat-linux-gnu

    The one from Fedora 27.

    > > If you want generated/map-shift.h to be rebuilt each time you run 'make' so
    > > that it can take a new SHIFT argument, that's fine, but let's not make users
    > > run 'make mapshift' before an actual 'make' will work, which is where we're at
    > > with v4.17 with my commit reverted.
    >
    > I don't want it to be rebuilt, I want it to be checked before each
    > build, regenerated if SHIFT has changed, and everything to rebuild if
    > it has changed.

    Sure, sounds good.

    \
     
     \ /
      Last update: 2018-07-16 23:09    [W:7.276 / U:1.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site