Messages in this thread | | | Date | Mon, 16 Jul 2018 15:08:20 -0600 | From | Ross Zwisler <> | Subject | Re: [PATCH 1/5] radix tree test suite: fix mapshift build target |
| |
On Mon, Jul 16, 2018 at 12:52:49PM -0700, Matthew Wilcox wrote: > On Mon, Jul 16, 2018 at 10:07:10AM -0600, Ross Zwisler wrote: <> > OK ... what version of make are you using? Because this works fine for me: > > $ git clone linux clean > $ cd clean > $ git checkout v4.17 > $ cd tools/testing/radix-tree/ > $ git revert 8d9fa88edd5e360b71765feeadb915d4066c9684 > $ make > > $ make --version > GNU Make 4.1 > Built for x86_64-pc-linux-gnu > > It's Debian's Version: 4.1-9.1
$ make --version GNU Make 4.2.1 Built for x86_64-redhat-linux-gnu
The one from Fedora 27.
> > If you want generated/map-shift.h to be rebuilt each time you run 'make' so > > that it can take a new SHIFT argument, that's fine, but let's not make users > > run 'make mapshift' before an actual 'make' will work, which is where we're at > > with v4.17 with my commit reverted. > > I don't want it to be rebuilt, I want it to be checked before each > build, regenerated if SHIFT has changed, and everything to rebuild if > it has changed.
Sure, sounds good.
| |