Messages in this thread | | | From | Masahiro Yamada <> | Date | Wed, 11 Jul 2018 21:21:24 +0900 | Subject | Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig |
| |
2018-07-09 0:19 GMT+09:00 Christoph Hellwig <hch@lst.de>: > Instead of duplicating the source statements in every architecture just > do it once in the toplevel Kconfig file. > > Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of > the top-level Kconfig into arch/Kconfig so that don't violate ordering > constraits while keeping a sensible menu structure. > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig > index dd4f3d3e644f..7ab7b148181b 100644 > --- a/arch/sh/Kconfig > +++ b/arch/sh/Kconfig > @@ -168,10 +168,6 @@ config PGTABLE_LEVELS > default 3 if X2TLB > default 2 > > -source "init/Kconfig" > - > -source "kernel/Kconfig.freezer" > - > menu "System type" > > # > @@ -553,8 +549,6 @@ endchoice > > endif > > -source "arch/sh/mm/Kconfig"
I noticed at least sh is broken because "arch/sh/mm/Kconfig" is no longer included by anyone.
I am not doing further tests.
Please test *ALL* architectures.
If possible, matrix tests (arch, config-target), where arch = arm, arm64, ... config-target = allyesconfig, allnoconfig, alldefconfig, ...
Note: scripts/diffconf is helpful.
-- Best Regards Masahiro Yamada
| |