lkml.org 
[lkml]   [2018]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf/core: fix possible spectre-v1 write
Hi Mark,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.18-rc4 next-20180710]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Mark-Rutland/perf-core-fix-possible-spectre-v1-write/20180711-023735
config: i386-randconfig-s0-201827 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

kernel/events/core.c: In function 'sw_perf_event_destroy':
>> kernel/events/core.c:8158:13: error: implicit declaration of function 'array_index_nospec' [-Werror=implicit-function-declaration]
event_id = array_index_nospec(event_id, PERF_COUNT_SW_MAX);
^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/array_index_nospec +8158 kernel/events/core.c

8154
8155 static void sw_perf_event_destroy(struct perf_event *event)
8156 {
8157 u64 event_id = event->attr.config;
> 8158 event_id = array_index_nospec(event_id, PERF_COUNT_SW_MAX);
8159
8160 WARN_ON(event->parent);
8161
8162 static_key_slow_dec(&perf_swevent_enabled[event_id]);
8163 swevent_hlist_put();
8164 }
8165

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-07-10 23:13    [W:0.054 / U:1.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site