lkml.org 
[lkml]   [2018]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 5/5] staging: fsl-dpaa2/eth: Remove Rx frame size check
Date
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Monday, July 9, 2018 10:28 PM
> To: Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
> Cc: gregkh@linuxfoundation.org; devel@driverdev.osuosl.org; linux-
> kernel@vger.kernel.org; Ioana Ciornei <ioana.ciornei@nxp.com>
> Subject: Re: [PATCH 5/5] staging: fsl-dpaa2/eth: Remove Rx frame size check
>
> On Mon, Jul 09, 2018 at 10:01:11AM -0500, Ioana Radulescu wrote:
> > @@ -2385,6 +2365,12 @@ static int netdev_init(struct net_device
> *net_dev)
> >
> > /* Set MTU upper limit; lower limit is 68B (default value) */
> > net_dev->max_mtu = DPAA2_ETH_MAX_MTU;
> > + err = dpni_set_max_frame_length(priv->mc_io, 0, priv->mc_token,
> > + (u16)DPAA2_ETH_MFL);
>
> The cast was there in the original code so this is not a comment on this
> particular patch (which seems fine) but there is no need to cast.
>
> Generally it's best to avoid unnecessary casts. As a human reader, I
> find the cast confusing. It indicates that DPAA2_ETH_MFL somehow
> requires special handling. Perhaps it's negative or we are trying to
> truncate away the high bits. But neither of those things really make
> sense.
>
> From a static analysis perspective if DPAA2_ETH_MFL doesn't fit nicely
> then we would want to generate a warning. But the cast explicitly
> disables the check.

I really don't remember why the cast was there in the first place.
It doesn't look like it's needed anymore, DPAA2_ETH_MFL has a
positive value (around 10K) that fits just fine inside a u16.

I see Greg already applied the patch, so I'll send a separate one to
remove the cast.

Thanks,
Ioana

\
 
 \ /
  Last update: 2018-07-10 17:56    [W:0.060 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site