Messages in this thread | | | Subject | Re: [PATCH 2/3] selftests/android: initialize heap_type to avoid compiling warning | From | Shuah Khan <> | Date | Tue, 10 Jul 2018 08:50:36 -0600 |
| |
Hi Li Zhijian,
On 07/01/2018 09:53 PM, Li Zhijian wrote: > root@vm-lkp-nex04-8G-7 ~/linux-v4.18-rc2/tools/testing/selftests/android# make > make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. > make[1]: Entering directory '/root/linux-v4.18-rc2/tools/testing/selftests/android/ion' > gcc -I. -I../../../../../drivers/staging/android/uapi/ -I../../../../../usr/include/ -Wall -O2 -g ionapp_export.c ipcsocket.c ionutils.c -o ionapp_export > ionapp_export.c: In function 'main': > ionapp_export.c:91:2: warning: 'heap_type' may be used uninitialized in > this function [-Wmaybe-uninitialized] > printf("heap_type: %ld, heap_size: %ld\n", heap_type, heap_size); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > CC: Shuah Khan <shuah@kernel.org> > CC: Pintu Agarwal <pintu.ping@gmail.com> > Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> > --- > tools/testing/selftests/android/ion/ionapp_export.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/testing/selftests/android/ion/ionapp_export.c b/tools/testing/selftests/android/ion/ionapp_export.c > index a944e72..e3435c2 100644 > --- a/tools/testing/selftests/android/ion/ionapp_export.c > +++ b/tools/testing/selftests/android/ion/ionapp_export.c > @@ -49,6 +49,7 @@ int main(int argc, char *argv[]) > return -1; > } > > + heap_type = -1UL;
Initialize it to one of the valid types. ION_HEAP_TYPE_SYSTEM is one choice.
> heap_size = 0; > flags = 0; > > @@ -82,6 +83,12 @@ int main(int argc, char *argv[]) > } > } > > + if (heap_type == -1UL) { > + printf("heap_type is invalid\n"); > + print_usage(argc, argv); > + exit(1); > + }
This check isn't necessary. The test requires two arguments, -i <heap id> and -s <size in bytes> and won't run without either one of them. heap_type is going to be ION_HEAP_TYPE_SYSTEM or ION_HEAP_TYPE_SYSTEM_CONTIG at this point.
Interesting. Looks like this test doesn't cover all ion_heap_types.
thanks, -- Shuah
| |