Messages in this thread | | | Subject | Re: [PATCH v5 4/6] bus: ti-sysc: Add support for software reset | From | Faiz Abbas <> | Date | Tue, 10 Jul 2018 18:50:14 +0530 |
| |
Hi Tony,
On Tuesday 10 July 2018 05:12 PM, Tony Lindgren wrote: > Hi, > > * Faiz Abbas <faiz_abbas@ti.com> [180709 16:50]: >> Add support for the software reset of a target interconnect >> module using its sysconfig and sysstatus registers. > ... >> --- a/drivers/bus/ti-sysc.c >> +++ b/drivers/bus/ti-sysc.c > ... >> +static int sysc_reset(struct sysc *ddata) >> +{ >> + int offset = ddata->offsets[SYSC_SYSCONFIG]; >> + int val = sysc_read(ddata, offset); > > Testing with omap4 sysc dts data I noticed we already > have modules where there is only rev register and no > SYSC_SYSCONFIG. So not using legacy mode. The > above offset with -ENODEV value will not work :) > > I added some more checks and moved them to the reset > function.
Great. Thanks for the fix.
Thanks, Faiz
| |