Messages in this thread | | | From | Pavel Tatashin <> | Date | Sun, 1 Jul 2018 23:03:24 -0400 | Subject | Re: [PATCH v3 1/2] mm/sparse: add sparse_init_nid() |
| |
> Ah, yes, I misunderstood it, sorry for that. > > Then I have only one concern, for vmemmap case, if one section doesn't > succeed to populate its memmap, do we need to skip all the remaining > sections in that node?
Yes, in sparse_populate_node() we have the following:
294 for (pnum = pnum_begin; map_index < map_count; pnum++) { 295 if (!present_section_nr(pnum)) 296 continue; 297 if (!sparse_mem_map_populate(pnum, nid, NULL)) 298 break;
So, on the first failure, we even stop trying to populate other sections. No more memory to do so.
Pavel
| |