lkml.org 
[lkml]   [2018]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on
    On Sun, Jul 1, 2018 at 6:34 AM, Shawn Guo <shawnguo@kernel.org> wrote:
    > On Mon, Jun 25, 2018 at 08:34:11PM +0800, Robin Gong wrote:
    >> SW4 is one power rail for LPDDR2 on i.mx6sl-evk, so it should
    >> be kept always on. But it's disabled after switch disabled
    >> interface implemented in pfuze driver
    >> 'commit 5fe156f1cab4
    >> ("regulator: pfuze100: add enable/disable for switch")'.Thus,
    >> it breaks kernel bootup. Add 'regulator-always-on' for SW4.
    >>
    >> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
    >
    > Does that mean boards with existing DTB installed will stop working with
    > new kernel? That's bad, and the kernel commit should probably be
    > reverted.

    Yes, this is a good point.

    Anson,

    Should 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for
    switch") be reverted to avoid such breakage?

    \
     
     \ /
      Last update: 2018-07-02 01:33    [W:4.306 / U:0.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site