Messages in this thread | | | From | Fabio Estevam <> | Date | Sun, 1 Jul 2018 20:32:49 -0300 | Subject | Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on |
| |
On Sun, Jul 1, 2018 at 6:34 AM, Shawn Guo <shawnguo@kernel.org> wrote: > On Mon, Jun 25, 2018 at 08:34:11PM +0800, Robin Gong wrote: >> SW4 is one power rail for LPDDR2 on i.mx6sl-evk, so it should >> be kept always on. But it's disabled after switch disabled >> interface implemented in pfuze driver >> 'commit 5fe156f1cab4 >> ("regulator: pfuze100: add enable/disable for switch")'.Thus, >> it breaks kernel bootup. Add 'regulator-always-on' for SW4. >> >> Signed-off-by: Robin Gong <yibin.gong@nxp.com> > > Does that mean boards with existing DTB installed will stop working with > new kernel? That's bad, and the kernel commit should probably be > reverted.
Yes, this is a good point.
Anson,
Should 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch") be reverted to avoid such breakage?
| |