lkml.org 
[lkml]   [2018]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 207/220] i2c: gpio: initialize SCL to HIGH again
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wolfram Sang <wsa+renesas@sang-engineering.com>

    commit 12b731dd46d9ee646318e6e9dc587314a3908a46 upstream.

    It seems that during the conversion from gpio* to gpiod*, the initial
    state of SCL was wrongly switched to LOW. Fix it to be HIGH again.

    Fixes: 7bb75029ef34 ("i2c: gpio: Enforce open drain through gpiolib")
    Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
    Cc: stable@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/i2c/busses/i2c-gpio.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/i2c/busses/i2c-gpio.c
    +++ b/drivers/i2c/busses/i2c-gpio.c
    @@ -279,9 +279,9 @@ static int i2c_gpio_probe(struct platfor
    * required for an I2C bus.
    */
    if (pdata->scl_is_open_drain)
    - gflags = GPIOD_OUT_LOW;
    + gflags = GPIOD_OUT_HIGH;
    else
    - gflags = GPIOD_OUT_LOW_OPEN_DRAIN;
    + gflags = GPIOD_OUT_HIGH_OPEN_DRAIN;
    priv->scl = i2c_gpio_get_desc(dev, "scl", 1, gflags);
    if (IS_ERR(priv->scl))
    return PTR_ERR(priv->scl);

    \
     
     \ /
      Last update: 2018-07-01 18:51    [W:4.110 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site