Messages in this thread | | | Date | Sun, 1 Jul 2018 14:29:14 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v3 4/9] dm integrity: Remove VLA usage |
| |
On Fri, Jun 29, 2018 at 02:56:37PM -0700, Kees Cook wrote: > > This conversion was following the existing check (PAGE_SIZE / 8), and > not via an analysis of alg.digestsize users. Let me double-check. For > predefined stuff, it looks like the largest is: > > SKEIN1024_DIGEST_BIT_SIZE/8 == 128
This should be removed. We shouldn't allow generic or new crypto algorithms in staging.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |