lkml.org 
[lkml]   [2018]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 30/48] team: use netdev_features_t instead of u32
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 25ea66544bfd1d9df1b7e1502f8717e85fa1e6e6 ]

    This code was introduced in 2011 around the same time that we made
    netdev_features_t a u64 type. These days a u32 is not big enough to
    hold all the potential features.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/team/team.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/net/team/team.c
    +++ b/drivers/net/team/team.c
    @@ -1004,7 +1004,8 @@ static void team_port_disable(struct tea
    static void __team_compute_features(struct team *team)
    {
    struct team_port *port;
    - u32 vlan_features = TEAM_VLAN_FEATURES & NETIF_F_ALL_FOR_ALL;
    + netdev_features_t vlan_features = TEAM_VLAN_FEATURES &
    + NETIF_F_ALL_FOR_ALL;
    netdev_features_t enc_features = TEAM_ENC_FEATURES;
    unsigned short max_hard_header_len = ETH_HLEN;
    unsigned int dst_release_flag = IFF_XMIT_DST_RELEASE |

    \
     
     \ /
      Last update: 2018-06-09 17:33    [W:4.107 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site