lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 140/410] mtd: ubi: wl: Fix error return code in ubi_wl_init()
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wei Yongjun <weiyongjun1@huawei.com>

    commit 7233982ade15eeac05c6f351e8d347406e6bcd2f upstream.

    Fix to return error code -ENOMEM from the kmem_cache_alloc() error
    handling case instead of 0, as done elsewhere in this function.

    Fixes: f78e5623f45b ("ubi: fastmap: Erase outdated anchor PEBs during
    attach")
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/mtd/ubi/wl.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    --- a/drivers/mtd/ubi/wl.c
    +++ b/drivers/mtd/ubi/wl.c
    @@ -1925,8 +1925,10 @@ int ubi_wl_init(struct ubi_device *ubi,
    cond_resched();

    e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
    - if (!e)
    + if (!e) {
    + err = -ENOMEM;
    goto out_free;
    + }

    e->pnum = aeb->pnum;
    e->ec = aeb->ec;
    @@ -1966,8 +1968,10 @@ int ubi_wl_init(struct ubi_device *ubi,
    cond_resched();

    e = kmem_cache_alloc(ubi_wl_entry_slab, GFP_KERNEL);
    - if (!e)
    + if (!e) {
    + err = -ENOMEM;
    goto out_free;
    + }

    e->pnum = aeb->pnum;
    e->ec = aeb->ec;
    \
     
     \ /
      Last update: 2018-06-07 17:55    [W:3.011 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site