lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 348/410] can: cc770: Fix stalls on rt-linux, remove redundant IRQ ack
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Andri Yngvason <andri.yngvason@marel.com>

    commit f4353daf4905c0099fd25fa742e2ffd4a4bab26a upstream.

    This has been reported to cause stalls on rt-linux.

    Suggested-by: Richard Weinberger <richard@nod.at>
    Tested-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Andri Yngvason <andri.yngvason@marel.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/can/cc770/cc770.c | 15 ---------------
    1 file changed, 15 deletions(-)

    --- a/drivers/net/can/cc770/cc770.c
    +++ b/drivers/net/can/cc770/cc770.c
    @@ -447,15 +447,6 @@ static netdev_tx_t cc770_start_xmit(stru

    stats->tx_bytes += dlc;

    -
    - /*
    - * HM: We had some cases of repeated IRQs so make sure the
    - * INT is acknowledged I know it's already further up, but
    - * doing again fixed the issue
    - */
    - cc770_write_reg(priv, msgobj[mo].ctrl0,
    - MSGVAL_UNC | TXIE_UNC | RXIE_UNC | INTPND_RES);
    -
    return NETDEV_TX_OK;
    }

    @@ -683,12 +674,6 @@ static void cc770_tx_interrupt(struct ne
    /* Nothing more to send, switch off interrupts */
    cc770_write_reg(priv, msgobj[mo].ctrl0,
    MSGVAL_RES | TXIE_RES | RXIE_RES | INTPND_RES);
    - /*
    - * We had some cases of repeated IRQ so make sure the
    - * INT is acknowledged
    - */
    - cc770_write_reg(priv, msgobj[mo].ctrl0,
    - MSGVAL_UNC | TXIE_UNC | RXIE_UNC | INTPND_RES);

    stats->tx_packets++;
    can_get_echo_skb(dev, 0);
    \
     
     \ /
      Last update: 2018-06-07 17:12    [W:2.587 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site