lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 135/410] uas: Log error codes when logging errors
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hans de Goede <hdegoede@redhat.com>

    commit ce39fe6fa115d9fea0112c907773a400b98d2463 upstream.

    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/storage/uas.c | 17 ++++++++++++-----
    1 file changed, 12 insertions(+), 5 deletions(-)

    --- a/drivers/usb/storage/uas.c
    +++ b/drivers/usb/storage/uas.c
    @@ -928,7 +928,8 @@ static int uas_eh_bus_reset_handler(stru
    usb_unlock_device(udev);

    if (err) {
    - shost_printk(KERN_INFO, sdev->host, "%s FAILED\n", __func__);
    + shost_printk(KERN_INFO, sdev->host, "%s FAILED err %d\n",
    + __func__, err);
    return FAILED;
    }

    @@ -1188,13 +1189,16 @@ static int uas_post_reset(struct usb_int
    struct Scsi_Host *shost = usb_get_intfdata(intf);
    struct uas_dev_info *devinfo = (struct uas_dev_info *)shost->hostdata;
    unsigned long flags;
    + int err;

    if (devinfo->shutdown)
    return 0;

    - if (uas_configure_endpoints(devinfo) != 0) {
    + err = uas_configure_endpoints(devinfo);
    + if (err) {
    shost_printk(KERN_ERR, shost,
    - "%s: alloc streams error after reset", __func__);
    + "%s: alloc streams error %d after reset",
    + __func__, err);
    return 1;
    }

    @@ -1232,10 +1236,13 @@ static int uas_reset_resume(struct usb_i
    struct Scsi_Host *shost = usb_get_intfdata(intf);
    struct uas_dev_info *devinfo = (struct uas_dev_info *)shost->hostdata;
    unsigned long flags;
    + int err;

    - if (uas_configure_endpoints(devinfo) != 0) {
    + err = uas_configure_endpoints(devinfo);
    + if (err) {
    shost_printk(KERN_ERR, shost,
    - "%s: alloc streams error after reset", __func__);
    + "%s: alloc streams error %d after reset",
    + __func__, err);
    return -EIO;
    }

    \
     
     \ /
      Last update: 2018-06-07 16:51    [W:2.784 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site