lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 400/410] bonding: fix the err path for dev hwaddr sync in bond_enslave
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Xin Long <lucien.xin@gmail.com>

    commit 5c78f6bfae2b10ff70e21d343e64584ea6280c26 upstream.

    vlan_vids_add_by_dev is called right after dev hwaddr sync, so on
    the err path it should unsync dev hwaddr. Otherwise, the slave
    dev's hwaddr will never be unsync when this err happens.

    Fixes: 1ff412ad7714 ("bonding: change the bond's vlan syncing functions with the standard ones")
    Signed-off-by: Xin Long <lucien.xin@gmail.com>
    Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
    Acked-by: Andy Gospodarek <andy@greyhouse.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    [bwh: Backported to 3.16: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/bonding/bond_main.c | 9 +++++----
    1 file changed, 5 insertions(+), 4 deletions(-)

    --- a/drivers/net/bonding/bond_main.c
    +++ b/drivers/net/bonding/bond_main.c
    @@ -1451,7 +1451,7 @@ int bond_enslave(struct net_device *bond
    if (res) {
    pr_err("%s: Error: Couldn't add bond vlan ids to %s\n",
    bond_dev->name, slave_dev->name);
    - goto err_close;
    + goto err_hwaddr_unsync;
    }

    prev_slave = bond_last_slave(bond);
    @@ -1626,9 +1626,6 @@ err_unregister:
    netdev_rx_handler_unregister(slave_dev);

    err_detach:
    - if (!bond_uses_primary(bond))
    - bond_hw_addr_flush(bond_dev, slave_dev);
    -
    vlan_vids_del_by_dev(slave_dev, bond_dev);
    if (bond->primary_slave == new_slave)
    bond->primary_slave = NULL;
    @@ -1642,6 +1639,10 @@ err_detach:
    }
    slave_disable_netpoll(new_slave);

    +err_hwaddr_unsync:
    + if (!bond_uses_primary(bond))
    + bond_hw_addr_flush(bond_dev, slave_dev);
    +
    err_close:
    slave_dev->priv_flags &= ~IFF_BONDING;
    dev_close(slave_dev);
    \
     
     \ /
      Last update: 2018-06-07 16:16    [W:3.000 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site