lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 405/410] net/mlx4_en: do not ignore autoneg in mlx4_en_set_pauseparam()
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ivan Vecera <ivecera@redhat.com>

    commit 278d436a476f69fc95d5c82bf61b6c2d02f4d44e upstream.

    The driver does not support pause autonegotiation so it should return
    -EINVAL when the function is called with non-zero autoneg.

    Cc: Amir Vadai <amirv@mellanox.com>
    Signed-off-by: Ivan Vecera <ivecera@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
    +++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
    @@ -476,6 +476,9 @@ static int mlx4_en_set_pauseparam(struct
    struct mlx4_en_dev *mdev = priv->mdev;
    int err;

    + if (pause->autoneg)
    + return -EINVAL;
    +
    priv->prof->tx_pause = pause->tx_pause != 0;
    priv->prof->rx_pause = pause->rx_pause != 0;
    err = mlx4_SET_PORT_general(mdev->dev, priv->port,
    \
     
     \ /
      Last update: 2018-06-07 16:13    [W:4.046 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site