lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] pwm: stm32: enforce dependency on CONFIG_MFD_STM32_TIMERS
    On Wed, 06 Jun 2018, Thierry Reding wrote:

    > On Fri, May 25, 2018 at 06:04:54PM +0200, Arnd Bergmann wrote:
    > > When compile-testing the pwm driver without also enabling the
    > > stm32_timers MFD, we run into a link error:
    > >
    > > drivers/pwm/pwm-stm32.o: In function `stm32_pwm_raw_capture.isra.6':
    > > pwm-stm32.c:(.text+0xcb0): undefined reference to `stm32_timers_dma_burst_read'
    > >
    > > We don't need the '|| COMPILE_TEST' here, since stm32_timers itself
    > > can be built with CONFIG_COMPILE_TEST on all architectures, so we do
    > > get the coverage through allmodconfig and randconfig builds even
    > > when we make it a hard dependency.
    > >
    > > Fixes: 7edf7369205b ("pwm: Add driver for STM32 plaftorm")
    > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > > ---
    > > drivers/pwm/Kconfig | 2 +-
    > > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > I think Lee already picked up a patch by Fabrice that fixes this by
    > adding a dummy implementation, see:
    >
    > http://patchwork.ozlabs.org/patch/916435/
    >
    > I prefer your solution, though, because the dummy is pretty redundant if
    > we can just make this a hard-dependency and still get the same coverage.

    The two patches aren't mutually exclusive. :)

    --
    Lee Jones [李琼斯]
    Linaro Services Technical Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2018-06-07 07:08    [W:2.358 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site