lkml.org 
[lkml]   [2018]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 19/19] serdev: Instantiate a ttydev serdev if acpi and of fails
Hi Andy,

On Tue, Jun 5, 2018 at 3:44 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, May 29, 2018 at 4:10 PM, Ricardo Ribalda Delgado
> <ricardo.ribalda@gmail.com> wrote:
> > If a serdev ttyport controller does not have an acpi nor an of child,
> > create a ttydev as a child of that controller.
> >
> > Doing this allows the removal, addition and replacement of ttydev devices
> > at runtime.
>
> > @@ -619,6 +619,27 @@ static inline int acpi_serdev_register_devices(struct serdev_controller *ctrl)
> > }
> > #endif /* CONFIG_ACPI */
> >
> > +
>
> Redundant blank line.

ACK
>
> > +#if IS_ENABLED(CONFIG_SERIAL_DEV_CTRL_TTYDEV)
>
> > - if (ret_of && ret_acpi) {
> > - dev_dbg(&ctrl->dev, "no devices registered: of:%d acpi:%d\n",
> > - ret_of, ret_acpi);
> > +
> > +#if IS_ENABLED(CONFIG_SERIAL_DEV_CTRL_TTYDEV)
> > + if (ret_of && ret_acpi && ctrl->is_ttyport)
> > + ret_tty = serdev_controller_add_ttydev(ctrl);
> > +#endif
> > +
> > + if (ret_of && ret_acpi && ret_tty) {
> > + dev_dbg(&ctrl->dev,
> > + "no devices registered: of:%d acpi:%d tty:%d\n",
> > + ret_of, ret_acpi, ret_tty);
> > ret = -ENODEV;
> > goto out_dev_del;
> > }
>
> Wouldn't be better to leave above if-condition and introduce your
> stuff inside it?

I have redesign the logic in the function on the next version

Thanks


--
Ricardo Ribalda

\
 
 \ /
  Last update: 2018-06-06 09:29    [W:0.079 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site