Messages in this thread | | | Date | Wed, 6 Jun 2018 16:47:19 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH V4 1/3] kallsyms: Simplify update_iter_mod() |
| |
Em Wed, Jun 06, 2018 at 03:13:00PM -0400, Steven Rostedt escreveu: > On Wed, 6 Jun 2018 15:59:14 -0300 > Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > > Em Wed, Jun 06, 2018 at 02:37:27PM -0400, Steven Rostedt escreveu: > > > On Wed, 6 Jun 2018 15:13:02 +0200 > > > Peter Zijlstra <peterz@infradead.org> wrote: > > > > > > > On Wed, Jun 06, 2018 at 03:54:09PM +0300, Adrian Hunter wrote: > > > > > The logic in update_iter_mod() is overcomplicated and gets worse every time > > > > > another get_ksymbol_* function is added. > > > > > > > > > > In preparation for adding another get_ksymbol_* function, simplify logic in > > > > > update_iter_mod(). > > > > > > > > > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> > > > > > Acked-by: Andi Kleen <ak@linux.intel.com> > > > > > > > > Both Daniel and Steven touched this function last year, let's also Cc > > > > them. > > > > > > Thanks for Ccing me. I tested the patch to make sure my changes still > > > work and they do: > > > > > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > > > Since you said you tested the patch, may I replace the Acked-by with the > > stronger Tested-by? > > Well, I only tested it against the changes I made earlier. I didn't do > any other testing, which is why I'm reluctant to say "tested by". > > Perhaps it can be: > > Tested-by: (ftrace changes only) Steven Rostedt (VMware) <rostedt@goodmis.org>
I think that brings more useful information to the log, so should be useful.
- Arnaldo
| |