Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 6 Jun 2018 13:26:30 +0200 | Subject | Re: [PATCH] usb: dwc3: qcom: mark PM functions as __maybe_unused |
| |
On Fri, May 25, 2018 at 6:06 PM, Arnd Bergmann <arnd@arndb.de> wrote: > The #ifdef guards around these are wrong, resulting in warnings > in certain configurations: > > drivers/usb/dwc3/dwc3-qcom.c:244:12: error: 'dwc3_qcom_resume' defined but not used [-Werror=unused-function] > static int dwc3_qcom_resume(struct dwc3_qcom *qcom) > ^~~~~~~~~~~~~~~~ > drivers/usb/dwc3/dwc3-qcom.c:223:12: error: 'dwc3_qcom_suspend' defined but not used [-Werror=unused-function] > static int dwc3_qcom_suspend(struct dwc3_qcom *qcom) > > This replaces the guards with __maybe_unused annotations to shut up > the warnings and give better compile time coverage. > > Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |