lkml.org 
[lkml]   [2018]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] x86/iommu: Fix a typo in a macro parameter
From
On Wed, 6 Jun 2018 12:37:34 +0200 (CEST), Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 6 Jun 2018, Masatake YAMATO wrote:
>
> Can you please explain why 0 is the wrong value.

I don't know such constants, 0 and 1.

What I change is just the name of macro parameter as

s/detect/_detect/

I don't change the definition of macro.

Masatake YAMATO

> That's not a typo, that's
> a functional change and both the subject line and the changelog itself
> should be explanatory.
>
> Thanks,
>
> tglx
>
>> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
>> ---
>> arch/x86/include/asm/iommu_table.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
>> index 1fb3fd1a83c2..2a0d5f7d1ed1 100644
>> --- a/arch/x86/include/asm/iommu_table.h
>> +++ b/arch/x86/include/asm/iommu_table.h
>> @@ -66,7 +66,7 @@ struct iommu_table_entry {
>> #define IOMMU_INIT_POST(_detect) \
>> __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 0)
>>
>> -#define IOMMU_INIT_POST_FINISH(detect) \
>> +#define IOMMU_INIT_POST_FINISH(_detect) \
>> __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 1)
>>
>> /*
>> --
>> 2.17.0
>>
>>

\
 
 \ /
  Last update: 2018-06-06 13:16    [W:0.032 / U:5.960 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site