lkml.org 
[lkml]   [2018]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 06/14] coresight: allow stm to be built as a module
    Date
    Allow to build coresight-stm as a module, for ease of development.

    - Kconfig becomes a tristate, to allow =m
    - add a stm_remove function, for module unload
    - add a MODULE_DEVICE_TABLE for autoloading on boot

    Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Randy Dunlap <rdunlap@infradead.org>
    Cc: Suzuki K Poulose <Suzuki.Poulose@arm.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Russell King <linux@armlinux.org.uk>
    Signed-off-by: Kim Phillips <kim.phillips@arm.com>
    ---
    drivers/hwtracing/coresight/Kconfig | 5 ++++-
    drivers/hwtracing/coresight/coresight-stm.c | 20 +++++++++++++++++++-
    2 files changed, 23 insertions(+), 2 deletions(-)

    diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig
    index d1209f5acf76..8c5e5407b7dd 100644
    --- a/drivers/hwtracing/coresight/Kconfig
    +++ b/drivers/hwtracing/coresight/Kconfig
    @@ -79,8 +79,8 @@ config CORESIGHT_DYNAMIC_REPLICATOR
    trace data based on the traceid.

    config CORESIGHT_STM
    - bool "CoreSight System Trace Macrocell driver"
    depends on (ARM && !(CPU_32v3 || CPU_32v4 || CPU_32v4T)) || ARM64
    + tristate "CoreSight System Trace Macrocell driver"
    select CORESIGHT_LINKS_AND_SINKS
    select STM
    help
    @@ -89,6 +89,9 @@ config CORESIGHT_STM
    logging useful software events or data coming from various entities
    in the system, possibly running different OSs

    + To compile this driver as a module, choose M here: the
    + module will be called coresight-stm.
    +
    config CORESIGHT_CPU_DEBUG
    tristate "CoreSight CPU Debug driver"
    depends on ARM || ARM64
    diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c
    index c46c70aec1d5..c465e6bc66c8 100644
    --- a/drivers/hwtracing/coresight/coresight-stm.c
    +++ b/drivers/hwtracing/coresight/coresight-stm.c
    @@ -882,6 +882,17 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id)
    return ret;
    }

    +static int __exit stm_remove(struct amba_device *adev)
    +{
    + struct stm_drvdata *drvdata = dev_get_drvdata(&adev->dev);
    +
    + coresight_unregister(drvdata->csdev);
    +
    + stm_unregister_device(&drvdata->stm);
    +
    + return 0;
    +}
    +
    #ifdef CONFIG_PM
    static int stm_runtime_suspend(struct device *dev)
    {
    @@ -922,6 +933,8 @@ static const struct amba_id stm_ids[] = {
    { 0, 0},
    };

    +MODULE_DEVICE_TABLE(amba, stm_ids);
    +
    static struct amba_driver stm_driver = {
    .drv = {
    .name = "coresight-stm",
    @@ -930,7 +943,12 @@ static struct amba_driver stm_driver = {
    .suppress_bind_attrs = true,
    },
    .probe = stm_probe,
    + .remove = stm_remove,
    .id_table = stm_ids,
    };

    -builtin_amba_driver(stm_driver);
    +module_amba_driver(stm_driver);
    +
    +MODULE_AUTHOR("Pratik Patel <pratikp@codeaurora.org>");
    +MODULE_DESCRIPTION("Arm CoreSight System Trace Macrocell driver");
    +MODULE_LICENSE("GPL v2");
    --
    2.17.0
    \
     
     \ /
      Last update: 2018-06-05 23:07    [W:4.097 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site