lkml.org 
[lkml]   [2018]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 14/61] platform/chrome: cros_ec_lpc: remove redundant pointer request
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit d3b56c566d4ba8cae688baf3cca94425d57ea783 upstream.

    Pointer request is being assigned but never used, so remove it. Cleans
    up the clang warning:

    drivers/platform/chrome/cros_ec_lpc.c:68:2: warning: Value stored to
    'request' is never read

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Benson Leung <bleung@chromium.org>
    Cc: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/platform/chrome/cros_ec_lpc.c | 3 ---
    1 file changed, 3 deletions(-)

    --- a/drivers/platform/chrome/cros_ec_lpc.c
    +++ b/drivers/platform/chrome/cros_ec_lpc.c
    @@ -49,7 +49,6 @@ static int ec_response_timed_out(void)
    static int cros_ec_pkt_xfer_lpc(struct cros_ec_device *ec,
    struct cros_ec_command *msg)
    {
    - struct ec_host_request *request;
    struct ec_host_response response;
    u8 sum = 0;
    int i;
    @@ -62,8 +61,6 @@ static int cros_ec_pkt_xfer_lpc(struct c
    for (i = 0; i < ret; i++)
    outb(ec->dout[i], EC_LPC_ADDR_HOST_PACKET + i);

    - request = (struct ec_host_request *)ec->dout;
    -
    /* Here we go */
    outb(EC_COMMAND_PROTOCOL_3, EC_LPC_ADDR_HOST_CMD);


    \
     
     \ /
      Last update: 2018-06-05 19:05    [W:4.032 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site