lkml.org 
[lkml]   [2018]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: radio: aimslab: restore RADIO_ISA dependency
From
Date
On 06/05/2018 04:33 AM, Arnd Bergmann wrote:
> The patch that allowed all the ISA drivers to build across architectures
> accidentally removed one 'select' statement, which now causes a rare
> randconfig build failure in case all the other drivers are disabled:
>
> drivers/media/radio/radio-aimslab.o:(.data+0x0): undefined reference to `radio_isa_match'
> drivers/media/radio/radio-aimslab.o:(.data+0x4): undefined reference to `radio_isa_probe'
> drivers/media/radio/radio-aimslab.o:(.data+0x8): undefined reference to `radio_isa_remove'
>
> This puts the statement back where it belongs.
>
> Fixes: 258c524bdaab ("media: radio: allow building ISA drivers with COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/radio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
> index 8fa403c7149e..39b04ad924c0 100644
> --- a/drivers/media/radio/Kconfig
> +++ b/drivers/media/radio/Kconfig
> @@ -257,6 +257,7 @@ config RADIO_RTRACK
> tristate "AIMSlab RadioTrack (aka RadioReveal) support"
> depends on ISA || COMPILE_TEST
> depends on VIDEO_V4L2
> + select RADIO_ISA
> ---help---
> Choose Y here if you have one of these FM radio cards, and then fill
> in the port address below.
>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Reported-by: Randy Dunlap <rdunlap@infradead.org>
https://marc.info/?l=linux-next&m=152778594005254&w=2


thanks,
--
~Randy

\
 
 \ /
  Last update: 2018-06-05 17:21    [W:0.020 / U:0.504 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site