lkml.org 
[lkml]   [2018]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 11/21] drm/nouveau: use match_string() helper
    On Thu, May 31, 2018 at 2:11 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
    > match_string() returns the index of an array for a matching string,
    > which can be used instead of open coded variant.
    >

    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

    > Cc: Ben Skeggs <bskeggs@redhat.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: dri-devel@lists.freedesktop.org
    > Cc: nouveau@lists.freedesktop.org
    > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
    > ---
    > v2:
    > - handle err case before normal case - per Andy
    >
    > drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 13 +++++--------
    > 1 file changed, 5 insertions(+), 8 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
    > index 6d99f11..67ba2ac 100644
    > --- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
    > +++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
    > @@ -644,16 +644,13 @@ static int nv17_tv_create_resources(struct drm_encoder *encoder,
    > int i;
    >
    > if (nouveau_tv_norm) {
    > - for (i = 0; i < num_tv_norms; i++) {
    > - if (!strcmp(nv17_tv_norm_names[i], nouveau_tv_norm)) {
    > - tv_enc->tv_norm = i;
    > - break;
    > - }
    > - }
    > -
    > - if (i == num_tv_norms)
    > + i = match_string(nv17_tv_norm_names,
    > + num_tv_norms, nouveau_tv_norm);
    > + if (i < 0)
    > NV_WARN(drm, "Invalid TV norm setting \"%s\"\n",
    > nouveau_tv_norm);
    > + else
    > + tv_enc->tv_norm = i;
    > }
    >
    > drm_mode_create_tv_properties(dev, num_tv_norms, nv17_tv_norm_names);
    > --
    > 1.7.12.4
    >



    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2018-06-05 15:21    [W:4.289 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site