Messages in this thread | | | Date | Tue, 5 Jun 2018 11:02:36 +0530 | From | Viresh Kumar <> | Subject | Re: [greybus-dev] [PATCH] Staging:greybus Fix comparison to NULL |
| |
On 03-06-18, 08:52, Janani Sankara Babu wrote: > This patch replaces comparison of var to NULL with !var > > Signed-off-by: Janani Sankara Babu <jananis37@gmail.com> > --- > drivers/staging/greybus/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c > index dafa430..5d14a4e 100644 > --- a/drivers/staging/greybus/core.c > +++ b/drivers/staging/greybus/core.c > @@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle, > static const struct greybus_bundle_id * > greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id) > { > - if (id == NULL) > + if (!id)
It is pretty much personal preference and there is no good reason to accept this patch really.
-- viresh
| |