Messages in this thread | | | Date | Tue, 5 Jun 2018 08:21:37 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v3 04/10] mfd: da9063: Replace model with type |
| |
On Sat, 02 Jun 2018, Marek Vasut wrote:
> The model number stored in the struct da9063 is the same for all > variants of the da9063 since it is the chip ID, which is always > the same. Replace that with a separate identifier instead, which > allows us to discern the DA9063 variants by setting the type > based on either DT match or otherwise. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Steve Twiss <stwiss.opensource@diasemi.com> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> > Cc: linux-renesas-soc@vger.kernel.org > Acked-by: Mark Brown <broonie@kernel.org> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > V2: Drop useless cast of id->driver_data > V3: Fix kernel 0day error , s/dev_model/type/ > --- > drivers/mfd/da9063-core.c | 1 - > drivers/mfd/da9063-i2c.c | 5 +++-- > drivers/regulator/da9063-regulator.c | 6 +++--- > include/linux/mfd/da9063/core.h | 6 +++++- > 4 files changed, 11 insertions(+), 7 deletions(-)
For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |