Messages in this thread | | | Subject | Re: [PATCH] docs/admin-guide/mm: add high level concepts overview | From | Randy Dunlap <> | Date | Mon, 4 Jun 2018 08:53:25 -0700 |
| |
On 06/04/2018 05:22 AM, Mike Rapoport wrote: > Hi Randy, > > Thanks for the review! I always have trouble with articles :) > The patch below addresses most of your comments. > > On Fri, Jun 01, 2018 at 05:09:38PM -0700, Randy Dunlap wrote: >> On 05/29/2018 04:37 AM, Mike Rapoport wrote: >>> Hi, >>> >>> From 2d3ec7ea101a66b1535d5bec4acfc1e0f737fd53 Mon Sep 17 00:00:00 2001 >>> From: Mike Rapoport <rppt@linux.vnet.ibm.com> >>> Date: Tue, 29 May 2018 14:12:39 +0300 >>> Subject: [PATCH] docs/admin-guide/mm: add high level concepts overview >>> >>> The are terms that seem obvious to the mm developers, but may be somewhat > > Huh, I afraid it's to late to change the commit message :(
Sure.
>> There are [or: These are] >> >>> obscure for, say, less involved readers. >>> >>> The concepts overview can be seen as an "extended glossary" that introduces >>> such terms to the readers of the kernel documentation. >>> >>> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> >>> --- >>> Documentation/admin-guide/mm/concepts.rst | 222 ++++++++++++++++++++++++++++++ >>> Documentation/admin-guide/mm/index.rst | 5 + >>> 2 files changed, 227 insertions(+) >>> create mode 100644 Documentation/admin-guide/mm/concepts.rst >>> >>> diff --git a/Documentation/admin-guide/mm/concepts.rst b/Documentation/admin-guide/mm/concepts.rst >>> new file mode 100644 >>> index 0000000..291699c >>> --- /dev/null >>> +++ b/Documentation/admin-guide/mm/concepts.rst > > [...] > >>> +All this makes dealing directly with physical memory quite complex and >>> +to avoid this complexity a concept of virtual memory was developed. >>> + >>> +The virtual memory abstracts the details of physical memory from the >> >> virtual memory {system, implementation} abstracts >> >>> +application software, allows to keep only needed information in the >> >> software, allowing the VM to keep only needed information in the >> >>> +physical memory (demand paging) and provides a mechanism for the >>> +protection and controlled sharing of data between processes. >>> + > > My intention was "virtual memory concept allows ... and provides ..." > I didn't want to repeat "concept", to I've just omitted it. > > Somehow, I don't feel that "system" or "implementation" fit here...
OK. Thanks for the update.
> Subject: [PATCH] docs/admin-guide/mm/concepts.rst: grammar fixups
> The patch is mostly about adding 'a' and 'the' and updating indentation.
I would say that it's mostly about improving readability.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
-- ~Randy
| |