lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] blk-mq: return when BLK_MQ_S_STOPPED in blk_mq_run_work_fn
    On Mon, Jun 04, 2018 at 05:03:55PM +0800, Jianchao Wang wrote:
    > if hctx is stopped, don't run the queue in blk_mq_run_work_fn.
    >
    > Fixes: 15fe8a9 (blk-mq: remove blk_mq_delay_queue())
    > Cc: Ming Lei <ming.lei@redhat.com>
    > Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
    > ---
    > block/blk-mq.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/block/blk-mq.c b/block/blk-mq.c
    > index 9ce9cac..d0ee928 100644
    > --- a/block/blk-mq.c
    > +++ b/block/blk-mq.c
    > @@ -1578,7 +1578,7 @@ static void blk_mq_run_work_fn(struct work_struct *work)
    > * If we are stopped, don't run the queue.
    > */
    > if (test_bit(BLK_MQ_S_STOPPED, &hctx->state))
    > - clear_bit(BLK_MQ_S_STOPPED, &hctx->state);
    > + return;
    >
    > __blk_mq_run_hw_queue(hctx);
    > }
    > --
    > 2.7.4
    >

    Reviewed-by: Ming Lei <ming.lei@redhat.com>

    Thanks,
    Ming

    \
     
     \ /
      Last update: 2018-06-04 12:44    [W:3.199 / U:1.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site