lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 28/52] ASoC: Intel: sst: remove redundant variable dma_dev_name
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit 271ef65b5882425d500e969e875c98e47a6b0c86 upstream.

    The pointer dma_dev_name is assigned but never read, it is redundant
    and can therefore be removed.

    Cleans up clang warning:
    sound/soc/intel/common/sst-firmware.c:288:3: warning: Value stored to
    'dma_dev_name' is never read

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Cc: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/soc/intel/common/sst-firmware.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/sound/soc/intel/common/sst-firmware.c
    +++ b/sound/soc/intel/common/sst-firmware.c
    @@ -274,7 +274,6 @@ int sst_dma_new(struct sst_dsp *sst)
    struct sst_pdata *sst_pdata = sst->pdata;
    struct sst_dma *dma;
    struct resource mem;
    - const char *dma_dev_name;
    int ret = 0;

    if (sst->pdata->resindex_dma_base == -1)
    @@ -285,7 +284,6 @@ int sst_dma_new(struct sst_dsp *sst)
    * is attached to the ADSP IP. */
    switch (sst->pdata->dma_engine) {
    case SST_DMA_TYPE_DW:
    - dma_dev_name = "dw_dmac";
    break;
    default:
    dev_err(sst->dev, "error: invalid DMA engine %d\n",

    \
     
     \ /
      Last update: 2018-06-04 09:26    [W:4.028 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site