Messages in this thread | | | From | Anson Huang <> | Subject | Re: [PATCH 2/4] clk: imx6sl: remove clks_init_on array | Date | Sun, 3 Jun 2018 12:45:38 +0000 |
| |
Hi, Fabio
From Anson's iPhone 6
> 在 2018年6月3日,20:17,Fabio Estevam <festevam@gmail.com> 写道: > > Hi Anson, > >> On Sun, Jun 3, 2018 at 12:00 AM, Anson Huang <Anson.Huang@nxp.com> wrote: >> Clock framework will enable those clocks registered >> with CLK_IS_CRITICAL flag, so no need to have >> clks_init_on array during clock initialization now. >> >> Signed-off-by: Anson Huang <Anson.Huang@nxp.com> >> --- >> drivers/clk/imx/clk-imx6sl.c | 12 ------------ >> 1 file changed, 12 deletions(-) >> >> diff --git a/drivers/clk/imx/clk-imx6sl.c b/drivers/clk/imx/clk-imx6sl.c >> index 66b1dd1..eb6bcbf 100644 >> --- a/drivers/clk/imx/clk-imx6sl.c >> +++ b/drivers/clk/imx/clk-imx6sl.c >> @@ -104,10 +104,6 @@ static struct clk_onecell_data clk_data; >> static void __iomem *ccm_base; >> static void __iomem *anatop_base; >> >> -static const u32 clks_init_on[] __initconst = { >> - IMX6SL_CLK_IPG, IMX6SL_CLK_ARM, IMX6SL_CLK_MMDC_ROOT, >> -}; > > It looks like you missed to pass the CLK_IS_CRITICAL flag to these clocks.
The ARM and mmdc root are busy divider, the CLK_IS_CRITICAL flag is included by default when busy divider is registered. IPG’parent is AHB which is also a busy divider. And IPG itself has no gate, no need to add flag.
Anson. | |