lkml.org 
[lkml]   [2018]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] leds: ledtrig-morse: send out morse code
    On Thu, Jun 28, 2018 at 03:42:27PM +0200, Andreas Klinger wrote:
    > Send out a morse code by using LEDs.
    >
    > This is useful especially on embedded systems without displays to tell the
    > user about error conditions and status information.
    >
    > The trigger will be called "morse"
    >
    > The string to be send is written into the file morse_string and sent out
    > with a workqueue. Supported are letters and digits.
    >
    > With the file dot_unit the minimal time unit can be adjusted in
    > milliseconds.

    This is great stuff, nice work.

    But you need to document your new sysfs files in Documentation/ABI/
    somewhere, so that people know how to use this.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2018-06-28 17:39    [W:3.314 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site