Messages in this thread | | | Subject | Re: [PATCH net-next] tcp: replace LINUX_MIB_TCPOFODROP with LINUX_MIB_TCPRMEMFULLDROP for drops due to receive buffer full | From | Eric Dumazet <> | Date | Wed, 27 Jun 2018 07:48:54 -0700 |
| |
On 06/27/2018 04:50 AM, Yafang Shao wrote: > When sk_rmem_alloc is larger than the receive buffer and we can't > schedule more memory for it, the skb will be dropped. > > In above situation, if this skb is put into the ofo queue, > LINUX_MIB_TCPOFODROP is incremented to track it, > while if this skb is put into the receive queue, there's no record. > > So LINUX_MIB_TCPOFODROP is replaced with LINUX_MIB_TCPRMEMFULLDROP to track > this behavior.
Hi Yafang
I do not want to remove TCPOFODrop and mix multiple causes in one single counter.
Please take a look at commit a6df1ae9383697c to have the reasoning.
Thanks.
| |