lkml.org 
[lkml]   [2018]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/4] staging: rtl8723bs: use ether_addr_copy() in rtw_macaddr_cfg()
On Wed, Jun 27, 2018 at 02:56:00PM +0200, Michael Straube wrote:
> Should I add a thanks line to the commit message:
>
> Thanks to Dan Carpenter, Joe Perches and Andy Shevchenko.
>
> Or would that be considered as too much?

You can write whatever the heck you want... :P No one cares.

When it comes to credit, I do appreciate Reported-by tags because LWN
and employers do count those sometimes. I also think there should be a
tag for when you find a bug in a patch before the patch gets merged.
You wouldn't get the tag for complaining about white space and style
issue because that's easier and less important and, in a way,
complaining about style is its own reward. But so far we haven't
invented a tag for that.

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-06-27 15:13    [W:0.154 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site