Messages in this thread | | | Date | Tue, 26 Jun 2018 16:07:09 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH] objtool: Fix GCC 8 cold function processing without -freorder-functions |
| |
On Tue, Jun 26, 2018 at 09:43:27PM +0200, Peter Zijlstra wrote: > On Tue, Jun 26, 2018 at 01:44:05PM -0500, Josh Poimboeuf wrote: > > On Tue, Jun 26, 2018 at 07:31:18PM +0100, Allan Xavier wrote: > > > > Is there a particular concern you're trying to address by having the logic there > > > instead? > > > > Thanks for the patch and the excellent problem description. I think the > > concern is that the overlap might cause other unforeseen issues (now or > > in the future). > > Yeah, overlapping symbols are just really weird and unfortunate, I've no > idea what the GCC people were thinking. > > Note how find_symbol_containing() already more or less assumed !overlap.
If there are no objections to my patch, I'll run it through 0-day testing and post an official version tomorrow-ish if it doesn't break anything.
-- Josh
| |