lkml.org 
[lkml]   [2018]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] objtool: Fix GCC 8 cold function processing without -freorder-functions
On Tue, Jun 26, 2018 at 09:43:27PM +0200, Peter Zijlstra wrote:
> On Tue, Jun 26, 2018 at 01:44:05PM -0500, Josh Poimboeuf wrote:
> > On Tue, Jun 26, 2018 at 07:31:18PM +0100, Allan Xavier wrote:
>
> > > Is there a particular concern you're trying to address by having the logic there
> > > instead?
> >
> > Thanks for the patch and the excellent problem description. I think the
> > concern is that the overlap might cause other unforeseen issues (now or
> > in the future).
>
> Yeah, overlapping symbols are just really weird and unfortunate, I've no
> idea what the GCC people were thinking.
>
> Note how find_symbol_containing() already more or less assumed !overlap.

If there are no objections to my patch, I'll run it through 0-day
testing and post an official version tomorrow-ish if it doesn't break
anything.

--
Josh

\
 
 \ /
  Last update: 2018-06-26 23:08    [W:0.082 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site