lkml.org 
[lkml]   [2018]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] ARM: dts: pxa: fix the rtc controller
    On Tue, Jun 26, 2018 at 10:47 AM Robert Jarzmik <robert.jarzmik@free.fr> wrote:
    >
    > The RTC controller is fed by an external fixed 32kHz clock. Yet the
    > driver wants to acquire this clock, even though it doesn't make any use
    > of it, ie. doesn't get the rate to make calculation.
    >
    > Therefore, add the dummy clock in the PXA clock tree to make the driver
    > happy and working.
    >
    > Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
    > ---
    > arch/arm/boot/dts/pxa25x.dtsi | 4 ++++
    > arch/arm/boot/dts/pxa27x.dtsi | 4 ++++
    > 2 files changed, 8 insertions(+)
    >
    > diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.dtsi
    > index 95d59be97213..c6ca07e4626b 100644
    > --- a/arch/arm/boot/dts/pxa25x.dtsi
    > +++ b/arch/arm/boot/dts/pxa25x.dtsi
    > @@ -80,6 +80,10 @@
    > #pwm-cells = <1>;
    > clocks = <&clks CLK_PWM1>;
    > };
    > +
    > + rtc@40900000 {
    > + clocks = <&clks CLK_NONE>;

    Don't add fake clocks. Either add a real clock or fix the driver to
    not require a clock.

    Rob

    \
     
     \ /
      Last update: 2018-06-26 20:23    [W:3.118 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site