Messages in this thread | | | Date | Tue, 26 Jun 2018 10:17:12 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] NFC: llcp: fix nfc_llcp_send_ui_frame() lockup |
| |
On Mon, 25 Jun 2018 23:44:22 -0700 Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > The loop is still infinite, correct, but we have a preemption point now. > > Sure, net people can come with a much better solution, I'll be happy to > > scratch my patch. > > > > This can not be the right solution, think about current thread being real time, > cond_resched() might be a nop.
Good point! Bah, as one of the RT maintainers, I should have noticed that too :-p
I'm losing my touch.
-- Steve
> > We should probably not loop at all, or not use MSG_DONTWAIT. > > (And remove this useless "Could not allocate PDU" message) > > NFC maintainers should really take a look at this.
| |