lkml.org 
[lkml]   [2018]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: s390 qemu boot failure in -next
From
Date
On 26.06.2018 07:32, Georgi Guninski wrote:
> On Mon, Jun 25, 2018 at 09:27:59AM +0200, Christian Borntraeger wrote:
>> - /* Overwrite parameters in the kernel image, which are "rom" */
>> - strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline);
>
>> + strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline);
>
> Why not replace strcpy() with strncpy() or snprintf()?
> strcpy() may overflow.

This will be fixed by
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04227.html by
adding a check for a valid size.

Thomas

\
 
 \ /
  Last update: 2018-06-26 07:40    [W:0.454 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site