lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 net-next] mdio-mux-gpio: Remove VLA usage
From
Date
On Mon, 2018-06-25 at 15:09 -0700, Kees Cook wrote:
> In the quest to remove all stack VLA usage from the kernel[1], this
> allocates the values buffer during the callback instead of putting it
> on the stack.

[]

> diff --git a/drivers/net/phy/mdio-mux-gpio.c b/drivers/net/phy/mdio-mux-gpio.c
[]
> @@ -44,15 +44,21 @@ static int mdio_mux_gpio_switch_fn(int current_child, int desired_child,
> static int mdio_mux_gpio_probe(struct platform_device *pdev)
> {
[]
> + s = devm_kzalloc(&pdev->dev, sizeof(*s->values) * gpios->ndescs +
> + sizeof(*s), GFP_KERNEL);

Isn't this supposed to use your new struct_size()

\
 
 \ /
  Last update: 2018-06-26 00:23    [W:0.062 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site