lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] x86/vdso: Change return type to vm_fault_t for fault handlers
On Mon, Jun 25, 2018 at 8:55 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.

Whoa there.. Your commit message makes it sound like you're just
changing the return type, but:

> if (tsc_pg && vclock_was_used(VCLOCK_HVCLOCK))
> - ret = vm_insert_pfn(vma, vmf->address,
> + ret = vmf_insert_pfn(vma, vmf->address,
> vmalloc_to_pfn(tsc_pg));
> }
>
> - if (ret == 0 || ret == -EBUSY)
> - return VM_FAULT_NOPAGE;
> -
> - return VM_FAULT_SIGBUS;
> + return ret;

You're refactoring the code, too.

Please fix your changelog.

\
 
 \ /
  Last update: 2018-06-25 18:12    [W:0.037 / U:1.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site