lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V9] powercap/drivers/idle_injection: Add an idle injection framework
    From
    Date
    On 25/06/2018 10:23, Rafael J. Wysocki wrote:

    [ ... ]

    >> + * It is up to the user of this framework to provide a lock at an
    >> + * upper level to prevent stupid things to happen, like starting while
    >> + * we are unregistering.
    >> + */
    >
    > The English above and elsewhere needs some polishing IMO, but I can
    > take care of that. :-)

    I can give a try and if you are still unhappy, you change them in a
    better way.

    [ ... ]

    >> +static void idle_injection_setup(unsigned int cpu)
    >> +{
    >> + struct sched_param param = { .sched_priority = MAX_USER_RT_PRIO / 2 };
    >> +
    >> + set_freezable();
    >
    > Why do you need set_freezable() here?

    We don't want to continue injecting idle cycles when the system is
    suspended.




    --
    <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

    Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
    <http://twitter.com/#!/linaroorg> Twitter |
    <http://www.linaro.org/linaro-blog/> Blog

    \
     
     \ /
      Last update: 2018-06-25 13:53    [W:3.588 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site