lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding Style
On Sun, Jun 24, 2018 at 08:59:22AM -0700, Joe Perches wrote:
> Rather than doing individual patches for each line
> with a whitespace issue, I think it'd be better to
> do a single driver wide patch.
>
> Perhaps use a tool like:
>
> $ git ls-files drivers/staging/rtl8192u |
> xargs ./scripts/checkpatch.pl -f --fix-inplace --types=spacing
>
> where:
>
> $ git diff -w drivers/staging/rtl8192u/
>
> should not show a single difference.
>
> Then compile and commit that as a single patch with
> something like "use a more typical spacing style"
> as the commit message.
>

Thank you for that command. Hadn't found the "--types=spacing" option.

I'd fixed all the spacing issues in that file in a previous patch set. That
space issue was in a commented out section of code, which is why I missed it
previously. I think that file has all space issues cleared so there's only the
single fix in this patch.

\
 
 \ /
  Last update: 2018-06-25 13:47    [W:5.646 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site