Messages in this thread | | | Date | Tue, 26 Jun 2018 11:15:23 +0800 | From | kbuild test robot <> | Subject | Re: [PATCH] efi: Free existing memory map before installing new memory map |
| |
Hi Sai,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.18-rc2 next-20180625] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Sai-Praneeth-Prakhya/efi-Free-existing-memory-map-before-installing-new-memory-map/20180626-104301 config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/firmware//efi/memmap.c: In function 'efi_memmap_install': >> drivers/firmware//efi/memmap.c:199:2: error: implicit declaration of function 'efi_memmap_free'; did you mean 'vmemmap_free'? [-Werror=implicit-function-declaration] efi_memmap_free(efi.memmap.phys_map, efi.memmap.nr_map, efi.memmap.late); ^~~~~~~~~~~~~~~ vmemmap_free cc1: some warnings being treated as errors
vim +199 drivers/firmware//efi/memmap.c
180 181 /** 182 * efi_memmap_install - Install a new EFI memory map in efi.memmap 183 * @addr: Physical address of the memory map 184 * @nr_map: Number of entries in the memory map 185 * 186 * Unlike efi_memmap_init_*(), this function does not allow the caller 187 * to switch from early to late mappings. It simply uses the existing 188 * mapping function and installs the new memmap. 189 * 190 * Returns zero on success, a negative error code on failure. 191 */ 192 int __init efi_memmap_install(phys_addr_t addr, unsigned int nr_map) 193 { 194 struct efi_memory_map_data data; 195 196 efi_memmap_unmap(); 197 198 /* Free the memory allocated to the existing memory map */ > 199 efi_memmap_free(efi.memmap.phys_map, efi.memmap.nr_map, efi.memmap.late); 200 201 data.phys_map = addr; 202 data.size = efi.memmap.desc_size * nr_map; 203 data.desc_version = efi.memmap.desc_version; 204 data.desc_size = efi.memmap.desc_size; 205 206 return __efi_memmap_init(&data, efi.memmap.late); 207 } 208
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [unhandled content-type:application/gzip] | |