Messages in this thread | | | Date | Sun, 24 Jun 2018 23:16:30 +0200 | From | Stefan Agner <> | Subject | Re: [PATCH v7 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver |
| |
On 24.06.2018 21:50, Boris Brezillon wrote: > On Sun, 24 Jun 2018 21:22:28 +0200 > Stefan Agner <stefan@agner.ch> wrote: > >> + >> +static int tegra_nand_remove(struct platform_device *pdev) >> +{ >> + struct tegra_nand_controller *ctrl = platform_get_drvdata(pdev); >> + >> + nand_release(nand_to_mtd(ctrl->chip)); > > I still see nand_release() being used here. As I said in my review of > v6, it's not safe. Please use mtd_device_unregister() + nand_cleanup() > instead, and check the return code of mtd_device_unregister().
Whoops missed that one. Will send v8.
-- Stefan
> > With this addressed > > Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com> > >> + >> + clk_disable_unprepare(ctrl->clk); >> + >> + return 0; >> +} >> +
| |