lkml.org 
[lkml]   [2018]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86/crypto: Add missing RETs
    On Sun, 24 Jun 2018, Ingo Molnar wrote:
    > * Borislav Petkov <bp@alien8.de> wrote:
    >
    > > Lemme send a proper patch now...
    > >
    > > ---
    > > From: Borislav Petkov <bp@suse.de>
    > > Date: Sun, 17 Jun 2018 13:57:42 +0200
    > > Subject: [PATCH] x86/crypto: Add missing RETs
    > >
    > > Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms
    > > otherwise they run into INT3 padding due to
    > >
    > > 51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions")
    > >
    > > leading to spurious debug exceptions.
    > >
    > > Mike Galbraith <efault@gmx.de> took care of all the remaining callsites.
    >
    > Note that 51bad67ffbce has been zapped because it caused too many problems like
    > this, but the explicit RETs make sense nevertheless. When applying the patch
    > please don't include the SHA1 of the non-upstream (and probably never-upstream)
    > commit.

    We should really have something like that exactly to catch cases like this.

    Thanks,

    tglx

    \
     
     \ /
      Last update: 2018-06-24 09:13    [W:6.390 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site