Messages in this thread | | | Subject | Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier | From | Michel Dänzer <> | Date | Fri, 22 Jun 2018 09:38:30 +0200 |
| |
On 2018-06-21 10:48 PM, Lyude Paul wrote: > This fixes a regression I accidentally reduced that was picked up by > kasan, where we were checking the CRTC atomic states after DRM's helpers > had already freed them. Example: > > [...] > > So, we fix this by counting the number of CRTCs this atomic commit disabled > early on in the function before their atomic states have been freed, then use > that count later to do the appropriate number of RPM puts at the end of the > function. > > Fixes: 97028037a38ae ("drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()") > Signed-off-by: Lyude Paul <lyude@redhat.com> > Cc: Michel Dänzer <michel@daenzer.net> > Reported-by: Michel Dänzer <michel@daenzer.net>
Actually, it was reported by Tom St Denis <tom.stdenis@amd.com>. With that fixed,
Acked-by: Michel Dänzer <michel.daenzer@amd.com>
(needs review by DC folks)
-- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
| |