Messages in this thread | | | From | Vincent Guittot <> | Date | Fri, 22 Jun 2018 19:22:48 +0200 | Subject | Re: [PATCH v6 06/11] cpufreq/schedutil: use dl utilization tracking |
| |
On Fri, 22 Jun 2018 at 17:24, Peter Zijlstra <peterz@infradead.org> wrote: > > On Fri, Jun 08, 2018 at 02:09:49PM +0200, Vincent Guittot wrote: > > - * Ideally we would like to set util_dl as min/guaranteed freq and > > - * util_cfs + util_dl as requested freq. However, cpufreq is not yet > > - * ready for such an interface. So, we only do the latter for now. > > Please don't delete that comment. It is not less relevant.
ok i will keep it in next version
> > > -static inline unsigned long cpu_util_dl(struct rq *rq) > > +static inline unsigned long cpu_bw_dl(struct rq *rq) > > I think you forgot to fix-up ignore_dl_rate_limit().
yes you're right
| |